-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix circular imports when importing ReactDialog (#14352)
Fixes #14347 Contributed on behalf of Toro Cloud Signed-off-by: Rannie Peralta <[email protected]>
- Loading branch information
1 parent
67bdf05
commit 5b2836a
Showing
2 changed files
with
48 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
// ***************************************************************************** | ||
// Copyright (C) 2024 Toro Cloud Pty Ltd and others. | ||
// | ||
// This program and the accompanying materials are made available under the | ||
// terms of the Eclipse Public License v. 2.0 which is available at | ||
// http://www.eclipse.org/legal/epl-2.0. | ||
// | ||
// This Source Code may also be made available under the following Secondary | ||
// Licenses when the conditions for such availability set forth in the Eclipse | ||
// Public License v. 2.0 are satisfied: GNU General Public License, version 2 | ||
// with the GNU Classpath Exception which is available at | ||
// https://www.gnu.org/software/classpath/license.html. | ||
// | ||
// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 | ||
// ***************************************************************************** | ||
|
||
import * as assert from 'assert'; | ||
import * as React from 'react'; | ||
import { enableJSDOM } from '../test/jsdom'; | ||
|
||
let disableJSDOM = enableJSDOM(); | ||
|
||
import { ReactDialog } from './react-dialog'; | ||
|
||
class MyDialog extends ReactDialog<void> { | ||
constructor() { | ||
super({ title: '' }); | ||
} | ||
|
||
override get value(): void { | ||
return; | ||
} | ||
|
||
protected override render(): React.ReactNode { | ||
return <></>; | ||
} | ||
} | ||
|
||
describe('ReactDialog', () => { | ||
before(() => disableJSDOM = enableJSDOM()); | ||
after(() => disableJSDOM()); | ||
|
||
it('should be extended', () => { | ||
const dialog = new MyDialog(); | ||
assert.equal(dialog instanceof ReactDialog, true); | ||
}); | ||
}); |