[doc] Add ADR on support for forking table description #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcharfadi
changed the title
mcharfadi
force-pushed
the
mch/doc/adr-studio-table
branch
from
0cc8174
to
1e04602
Compare
sbegaudeau
requested changes
Nov 6, 2024
doc/adrs/168_add_support_for_forking_table_description_from_representation.adoc
Outdated
Show resolved
Hide resolved
doc/adrs/168_add_support_for_forking_table_description_from_representation.adoc
Outdated
Show resolved
Hide resolved
|
|
||
| == Disadvantages | ||
| * User Experience: The user that wants to make a change will need to reopen his representation after the changes. | ||
| * User Experience: Saved changes in the database from the previous representation will be irrelevant and deleted. |
There was a problem hiding this comment.
Why? I don't see why anything should be irrelevant and deleted
There was a problem hiding this comment.
I'm not sure what data we're going to store for a table and wanted to avoid possible issues.
I thought about the case where if we store the current width of a column and that column does not exist anymore after some changes on the forked studio.
mcharfadi
force-pushed
the
mch/doc/adr-studio-table
branch
4 times, most recently
from
a070195
to
c9374d3
Compare
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi
force-pushed
the
mch/doc/adr-studio-table
branch
from
c9374d3
to
78752d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.