Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[37] Convert into a plain Maven module #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Jun 29, 2024

  • There is now a single Maven module; the test code is directly in src/test/java.
  • Removed all Eclipse/PDE-specific settings.
  • Removed the Eclipse-specific code and tests which depended on it.
  • There is still an Eclipse project, but it is configured as an M2E project, node a plug-in (PDE).
  • The resulting JAR should still be OSGi-compliant, the produced MANIFEST.MF is the same as before (it may not be in sync with the POM version though).
  • Moved compiler settings to Java 17.
  • Removed some unused dependencies.
  • Added mvn wrapper and use it in the workflow to ensure a recent Maven version.
  • The resulting project can be imported in an Eclipse workspace and the test suites are green both when run from inside Eclipse and via mvn verify:

image

Bug: #37
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid marked this pull request as ready for review August 21, 2024 16:09
@pcdavid pcdavid linked an issue Aug 22, 2024 that may be closed by this pull request
Signed-off-by: Pierre-Charles David <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert into a plain Maven project/module
1 participant