Fix NPE in switch case #1714
Merged
Fix NPE in switch case #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 755 files 1 755 suites 1h 28m 26s ⏱️ Results for commit cf64b15. |
| nativeProxyProvider = switch (os) { | ||
| case Constants.OS_LINUX -> new ProxyProviderLinux(); | ||
| case Constants.OS_WIN32 -> new ProxyProviderWin32(); | ||
| default -> null; |
There was a problem hiding this comment.
@laeubi you could also just write ...case null, default -> null;. The switch can deal with null, if it's declared in the cases.
There was a problem hiding this comment.
I'm not sure if its not only the case on Java 21,... but even System.getProperty("osgi.os", "") would be possible... so many options :-D
There was a problem hiding this comment.
right, I sometimes forget that not everyone is on 21 yet. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.