Remove unused static method #21033
Merged
Remove unused static method #21033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r30shah is there a need to run internal tests for this since it only removes unused code? Or can you just run the openj9 tests? |
|
No, I think external tests are sufficient. |
r30shah
approved these changes
Jan 28, 2025
Removes generateInlineTest which is no longer used, as well as the NUM_PICS define which was only used in generateInlineTest Signed-off-by: Matthew Hall <[email protected]>
matthewhall2
force-pushed
the
cleanup_unused_code
branch
from
f3e23bd to
da3279c
Compare
done. thanks @r30shah |
|
Jenkins test sanity.functional,sanity.openjdk zlinux jdk21 |
r30shah
approved these changes
Jan 28, 2025
|
Merging changes as all test have been passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes out unused method
generateInlineTest.