Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the JIT bootstrap process #21003

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document the JIT bootstrap process #21003

wants to merge 1 commit into from

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Jan 23, 2025

Closes #12506

@dsouzai
Copy link
Contributor Author

dsouzai commented Jan 23, 2025

@a7ehuo could you please review?

a7ehuo
a7ehuo reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much Irwin for documenting the JIT bootstrap process! I just have a few very minor comments

doc/compiler/runtime/Bootstrap.md Outdated Show resolved Hide resolved
doc/compiler/runtime/Bootstrap.md Outdated Show resolved Hide resolved
doc/compiler/runtime/Bootstrap.md Outdated Show resolved Hide resolved
doc/compiler/runtime/Bootstrap.md Outdated Show resolved Hide resolved
doc/compiler/runtime/Bootstrap.md Outdated Show resolved Hide resolved
@dsouzai
Copy link
Contributor Author

dsouzai commented Jan 24, 2025

@a7ehuo good for another review

a7ehuo
a7ehuo reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! I just have two minor comments

doc/compiler/runtime/Bootstrap.md Outdated Show resolved Hide resolved
doc/compiler/runtime/Bootstrap.md Outdated Show resolved Hide resolved
@dsouzai
Document the JIT bootstrap process
37cf562 
[ci-skip]

Signed-off-by: Irwin D'Souza <[email protected]>
a7ehuo
a7ehuo approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! LGTM

@dsouzai
Copy link
Contributor Author

dsouzai commented Jan 24, 2025

@0xdaryl could you review/merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7ehuo a7ehuo a7ehuo approved these changes

Assignees
No one assigned
Labels
comp:doc comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document compiler bootstrap process
2 participants
@dsouzai @a7ehuo