Fix OMR_ENV_OPENXL Usage #20928
Open
Fix OMR_ENV_OPENXL Usage #20928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midronij
changed the title
|
Moving to draft state until consensus is reached with respect to the configuration pattern. |
midronij
force-pushed
the
openxl-config
branch
2 times, most recently
from
70d8ec7 to
71c8aaa
Compare
keithc-ca
requested changes
Jan 14, 2025
The environment variable OMR_ENV_OPENXL was created in a previous contribution to indicate if the C/C++ compiler being used was OpenXL. However, this can be done in a way that remains consistent to other platforms by using the already existing OMR_TOOLCHAIN variable instead. Signed-off-by: midronij <[email protected]>
midronij
force-pushed
the
openxl-config
branch
from
71c8aaa to
667ba48
Compare
|
@keithc-ca since the OMR side contribution is just about finalized, I'll unmark this as a draft. If you have any further feedback to give, then please feel free to review my changes again. Otherwise, I think we can get the CI tests started. |
keithc-ca
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
This looks good, but will need to wait until the OMR change promotes to the openj9 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up usage ofOMR_ENV_OPENXLmake/config filesReplace all usages of OMR_ENV_OPENXL with the already existing env variable,
OMR_TOOLCHAINDepends on eclipse-omr/omr#7605