CRIU DebugOnRestore mode is disabled when debug events are hooked #20891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonFengJ9
force-pushed
the
debugonrestore
branch
from
3d718c4 to
aafa2b2
Compare
dsouzai
reviewed
Jan 8, 2025
|
Marking this as WIP until a proper way determining the debug on restore mode is found. |
JasonFengJ9
force-pushed
the
debugonrestore
branch
from
aafa2b2 to
2d0e38e
Compare
isDebugOnRestoreEnabled() returns false if some debug-specific flags/events are enabled/hooked, this matches J9::Options::isFSDNeeded() in compiler/control/J9Options.cpp; DebugOnRestore mode is enabled when CRIU is enabled, -XX:+DebugOnRestore is specified, JDWP is not enabled, and no debug-specific flags/events are enabled/hooked; When DebugOnRestore mode is enabled, debug related events and hooks can't be enabled or hooked pre-checkpoint, isDebugAgentDisabled() returns TRUE in this case, otherwise FALSE. Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
force-pushed
the
debugonrestore
branch
from
2d0e38e to
a048979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIU
DebugOnRestoremode is disabled when debug events are hookedisDebugOnRestoreEnabled()returnsfalseif some debug-specific flags/events are enabled/hooked, this matchesJ9::Options::isFSDNeeded()incompiler/control/J9Options.cpp;DebugOnRestoremode is enabled when CRIU is enabled,-XX:+DebugOnRestoreis specified, JDWP is not enabled, and no debug-specific flags/events are enabled/hooked;When
DebugOnRestoremode is enabled, debug-related events and hooks can't be enabled or hooked pre-checkpoint,isDebugAgentDisabled()returnsTRUEin this case, otherwiseFALSE.Signed-off-by: Jason Feng [email protected]