Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize StringLatin1.inflate([BI[BII)V #20867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Recognize StringLatin1.inflate([BI[BII)V #20867

wants to merge 1 commit into from

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Dec 23, 2024

This commit recognizes StringLatin1.inflate([BI[BII)V and changes it to an arraytranslate node with boundary checks.

@knn-k knn-k added the comp:jit label Dec 23, 2024
@knn-k
Copy link
Contributor Author

knn-k commented Dec 23, 2024

Jenkins test sanity plinux,xlinux jdk17

@knn-k knn-k force-pushed the recognizeLatin1Inflate branch from c7c5e71 to 06e8758 Compare January 8, 2025 07:06
@knn-k
Copy link
Contributor Author

knn-k commented Jan 8, 2025

Jenkins test sanity plinux,xlinux jdk11,jdk17

@BradleyWood
Copy link
Member

We have code-gen intrinsics for this function on some platforms (like x86). We need to know that doesn't cause a performance regression.

@knn-k
Copy link
Contributor Author

knn-k commented Jan 8, 2025

@BradleyWood The existing method recognition is for StringLatin1.inflate([BI[CII)V, and this PR targets a method with a different signature, StringLatin1.inflate([BI[BII)V.

@knn-k knn-k force-pushed the recognizeLatin1Inflate branch 3 times, most recently from 372ee50 to 021979d Compare January 21, 2025 05:59
@knn-k
Copy link
Contributor Author

knn-k commented Jan 23, 2025

Jenkins test sanity plinux,xlinux jdk11,jdk21

@knn-k knn-k force-pushed the recognizeLatin1Inflate branch from 021979d to 9797b53 Compare January 27, 2025 08:04
@knn-k
Copy link
Contributor Author

knn-k commented Jan 27, 2025

Jenkins test sanity plinux,xlinux jdk11,jdk21

@knn-k
Recognize StringLatin1.inflate([BI[BII)V
c386705 
This commit recognizes StringLatin1.inflate([BI[BII)V and changes it to
an arraytranslate node with boundary checks.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k knn-k force-pushed the recognizeLatin1Inflate branch from 9797b53 to c386705 Compare January 27, 2025 08:29
@knn-k
Copy link
Contributor Author

knn-k commented Jan 27, 2025

Jenkins test sanity plinux,xlinux jdk11,jdk21

@knn-k knn-k mentioned this pull request Jan 27, 2025
Open
@knn-k knn-k marked this pull request as ready for review January 27, 2025 13:18
@knn-k knn-k requested a review from dsouzai as a code owner January 27, 2025 13:18
@knn-k
Copy link
Contributor Author

knn-k commented Jan 28, 2025

This commit adds 5 ifcmplt nodes for array boundary checks, but many of them are eliminated by the following optimizations.

@knn-k
Copy link
Contributor Author

knn-k commented Jan 30, 2025

@0xdaryl Please assign someone appropriate for review. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees
No one assigned
Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knn-k @BradleyWood