Generate inline superclass test for Class.isAssignableFrom on Z #20855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhall2
force-pushed
the
assignableFrom_genSuperclassTest
branch
2 times, most recently
from
093a9de to
e0ce9ec
Compare
matthewhall2
force-pushed
the
assignableFrom_genSuperclassTest
branch
8 times, most recently
from
32f0761 to
4da8d70
Compare
matthewhall2
force-pushed
the
assignableFrom_genSuperclassTest
branch
from
4da8d70 to
6d94a59
Compare
matthewhall2
force-pushed
the
assignableFrom_genSuperclassTest
branch
3 times, most recently
from
d4d8676 to
ce999ca
Compare
|
@r30shah can you review please? |
r30shah
requested changes
Jan 3, 2025
| generateS390BranchInstruction(cg, TR::InstOpCode::BRC, TR::InstOpCode::COND_BRC, node, failLabel); | ||
| } | ||
| } | ||
| genTestIsSuper(cg, node, fromClassReg, toClassReg, sr1, sr2, NULL, NULL, toClassDepth, failLabel, successLabel, helperCallLabel, deps, NULL, false, NULL, NULL); |
There was a problem hiding this comment.
getTestIsSuper is used by checkAssignableFrom old code and old instance of and checkcast code. We should make the changes is new isAssignableFrom with intention to clean-up old code in mind. I would take a look at genTestIsSuper and genInstanceOfOrCheckcastSuperClassTest and refactor common code to the single function. Currently the code in both is repeated twice with some subtle changes
adds superclass check checks for class depth at compile time to skip over superclass test for the case when toClassDepth > fromClassDepth Signed-off-by: Matthew Hall <[email protected]>
matthewhall2
force-pushed
the
assignableFrom_genSuperclassTest
branch
from
e49baeb to
63470fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds superclass check
checks for class depth at compile time to skip over superclass test for the case when toClassDepth > fromClassDepth
This PR does not enable the change. It will be enabled in a later PR.
tests on this branch:
vmfarm
jenkins personal
tests on branch with change enabled:
vmfarm
jenkins personal