Document conditional directives in x/codegen/J9TreeEvaluator.cpp

[dylanjtuttle]

Add missing comments to #else and #endif directives in runtime/compiler/x/codegen/J9TreeEvaluator.cpp to document the conditions that they are closing, improving readability and aligning with the OMR C and C++ Coding Standards.

[dylanjtuttle]

@hzongaro Could I get a review on this if you get a chance? It's only documentation, so it hopefully shouldn't require any PR builds.

[hzongaro]

closing, improving readability and aligning with the OMR C and C++ Coding Standards.

Thanks, @dylanjtuttle! Although that coding standard document doesn't mention this, the compiler source code in OpenJ9 and OMR has always followed — though not especially rigidly — its own coding style.

Having said that, this particular change can certainly help with readability. @dsouzai, is this something that should be considered in the context of issue eclipse-omr/omr#7434? I'm assuming the final format selected for OMR's compiler code will eventually strongly influence formatting of compiler code in OpenJ9.

@dylanjtuttle, may I suggest you add a comment to the OMR issue?

[dsouzai]

@dsouzai, is this something that should be considered in the context of issue eclipse-omr/omr#7434? I'm assuming the final format selected for OMR's compiler code will eventually strongly influence formatting of compiler code in OpenJ9.

Yeah it's probably a good idea, especially since this exact thing was explicitly discussed in the original OMR architecture meeting that introduced the code formatting proposal.