Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to indicate if ROMclass is from SCC #20029

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add flag to indicate if ROMclass is from SCC #20029

merged 2 commits into from
Sep 17, 2024

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Aug 21, 2024 •
edited
Loading

Taking over from #19637

Documentation update: eclipse-openj9/openj9-docs#1406

@theresa-m theresa-m marked this pull request as ready for review September 11, 2024 15:52
hangshao0
hangshao0 reviewed Sep 12, 2024
View reviewed changes
runtime/oti/j9javaaccessflags.h Outdated
@@ -99,6 +99,7 @@
* See map in ROMClassBuilder::computeExtraModifiers for
* available slots.
*/
#define J9AccClassIsStoredInSCC 0x20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J9AccClassIsShared is a better name.

@hangshao0
Copy link
Contributor

Shared cache created by previous JDKs without this change will become incompatible with new JDKs containing this change. The cache generation needs to be incremented to 45:

openj9/runtime/shared_common/OSCache.hpp

Line 64 in 216f345

#define OSCACHE_CURRENT_CACHE_GEN 43

The cache generation change should be documented in the release notes. The next release picking up this change is 0.49.
Please create a documentation issue for the cache generation number change. You can look at eclipse-openj9/openj9-docs#248 as an example.

@theresa-m theresa-m mentioned this pull request Sep 13, 2024
Open
@theresa-m
Copy link
Contributor Author

Thanks @hangshao0 I opened this documentation issue eclipse-openj9/openj9-docs#1406

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended amac jdk21

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended xlinux jdk17

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended zlinux jdk8

@hangshao0
Copy link
Contributor

PR builds (all passed):
https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/6034/
https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/6035/
https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/6036/

@hangshao0 hangshao0 merged commit a6c2ea0 into eclipse-openj9:master Sep 17, 2024
2 checks passed
@dmitripivkine dmitripivkine mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangshao0 hangshao0 hangshao0 approved these changes

Assignees
No one assigned
Labels
comp:vm depends:doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theresa-m @hangshao0 @tajila