Move willBeEvaluatedAsCallByCodeGen to OpenJ9 #7516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The willBeEvaluatedAsCallByCodeGen implementation for x is almost entirely guarded by the J9_PROJECT_SPECIFIC macro. If the macro is not set, it always returns true which is what the default implementation already does. Since this implementation is only meaningful to OpenJ9, it is being moved there. willNotInlineCompareAndSwapNative is only called from this implementation of willBeEvaluatedAsCallByCodeGen so it is being moved as well. Signed-off-by: jimmyk <[email protected]>
|
@hzongaro When you have some time, could you look at this? |
hzongaro
approved these changes
Nov 1, 2024
|
Jenkins build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
willBeEvaluatedAsCallByCodeGenimplementation for x is almost entirely guarded by theJ9_PROJECT_SPECIFICmacro. If the macro is not set, it always returns true which is what the default implementation already does. Since this implementation is only meaningful to OpenJ9, it is being moved there.willNotInlineCompareAndSwapNativeis only called from this implementation ofwillBeEvaluatedAsCallByCodeGenso it is being moved as well.Depends on:
eclipse-openj9/openj9#20469
The OpenJ9 PR needs to be merged in either before or at the same time as this one.