Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update to monaco-editor-wrapper v5 #222

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaisalmen
Copy link
Contributor

@kaisalmen kaisalmen commented Mar 26, 2024

Instead of updating to v4 this will directly update to v5

  • Changes to core: Expose monaco-editor-wrapper as mew and monaco-editor-react as mer
  • Replace buildWorkerDefinition with new useWorkerFactory now available via monaco-editor-wrapper/workerFactory
  • Updated langium and monaco tutorial
  • All workers are now esm as the need is no longer given. Major browsers now support it.

Copy link

github-actions bot commented Mar 26, 2024

PR Preview Action v1.4.6
🚀 Deployed preview to https://eclipse-langium.github.io/langium-previews/pr-previews/pr-222/
on branch previews at 2024-04-26 13:08 UTC

@kaisalmen kaisalmen force-pushed the kaisalmen/monaco-editor-wrapper-v4 branch from dead9dc to 9ac3038 Compare March 26, 2024 15:43
@kaisalmen kaisalmen temporarily deployed to pull-request-preview March 26, 2024 15:45 — with GitHub Actions Inactive
@kaisalmen kaisalmen force-pushed the kaisalmen/monaco-editor-wrapper-v4 branch from 9ac3038 to 95d5bb7 Compare March 27, 2024 09:29
@kaisalmen kaisalmen temporarily deployed to pull-request-preview March 27, 2024 09:30 — with GitHub Actions Inactive
@kaisalmen kaisalmen force-pushed the kaisalmen/monaco-editor-wrapper-v4 branch from 95d5bb7 to 5f7fd6d Compare April 3, 2024 08:37
@kaisalmen kaisalmen marked this pull request as draft April 3, 2024 08:45
@kaisalmen kaisalmen changed the title Update to monaco-editor-wrapper v4 WIP: Update to monaco-editor-wrapper v4 Apr 3, 2024
@kaisalmen kaisalmen force-pushed the kaisalmen/monaco-editor-wrapper-v4 branch from 5f7fd6d to 495f7d5 Compare April 3, 2024 11:51
@kaisalmen kaisalmen temporarily deployed to pull-request-preview April 3, 2024 11:53 — with GitHub Actions Inactive
@kaisalmen kaisalmen force-pushed the kaisalmen/monaco-editor-wrapper-v4 branch 2 times, most recently from 2c75286 to f3ade49 Compare April 23, 2024 08:32
@kaisalmen kaisalmen temporarily deployed to pull-request-preview April 23, 2024 08:33 — with GitHub Actions Inactive
- Expose monaco-editor-wrapper as mew and monaco-editor-react as mer
- Replace buildWorkerDefinition with new useWorkerFactory
- Updated langium and monaco tutorial
- All workers are now esm
@kaisalmen kaisalmen force-pushed the kaisalmen/monaco-editor-wrapper-v4 branch from f3ade49 to 88a9785 Compare April 26, 2024 13:06
@kaisalmen kaisalmen marked this pull request as ready for review April 26, 2024 13:06
@kaisalmen kaisalmen changed the title WIP: Update to monaco-editor-wrapper v4 Update to monaco-editor-wrapper v4 Apr 26, 2024
@kaisalmen kaisalmen marked this pull request as draft May 16, 2024 10:07
@kaisalmen kaisalmen removed the request for review from montymxb May 16, 2024 10:07
@kaisalmen kaisalmen changed the title Update to monaco-editor-wrapper v4 WIP: Update to monaco-editor-wrapper v5 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant