Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support publishing of PR previews to the langium-previews repo #210

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Support publishing of PR previews to the langium-previews repo #210

merged 2 commits into from
Dec 14, 2023

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Dec 14, 2023

As requested in https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4075.

Additional changes that needed to be made for previews to be correctly displayed:

  • use relative links when generating the site
  • update playground to load additional js files relatively instead of absolutely

…po; ensure that relative links are used for building the website
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this 🚀

@spoenemann spoenemann merged commit 03b6fe9 into eclipse-langium:main Dec 14, 2023
1 check passed
@netomi netomi deleted the publish-to-previews-repo branch December 14, 2023 12:44
@msujew
Copy link
Member

msujew commented Dec 14, 2023

@netomi The preview deployment seems to fail. See here. rossjrw/pr-preview-action@183082fd714654433c8e2f6daedbfb4f20f2a94a doesn't seem to be a valid commit.

@netomi
Copy link
Contributor Author

netomi commented Dec 14, 2023

Created a PR to unpin this action. The action checks out itself based on the tag and that does not seem to work with a commit hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants