Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Link (https://github.com/eclipse-langium/langium-website/issues/187) #188

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Fixed Link (https://github.com/eclipse-langium/langium-website/issues/187) #188

merged 3 commits into from
Sep 28, 2023

Conversation

emilkrebs
Copy link
Contributor

montymxb
montymxb approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: link is good, approved!

msujew
msujew reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, can you also fix the incorrect links for eclipse-langium/langium-lox? See here for example.

@emilkrebs
Copy link
Contributor Author

Fixed eclipse-langium/langium-minilogo and eclipse-langium/langium-lox

msujew
msujew approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@msujew msujew merged commit 2b70c3c into eclipse-langium:main Sep 28, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montymxb montymxb montymxb approved these changes

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilkrebs @msujew @montymxb