Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domainmodel showcase #186

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Domainmodel showcase #186

merged 4 commits into from
Oct 13, 2023

Conversation

emilkrebs
Copy link
Contributor

Added an interactive live preview for the domainmodel language using d3.js

image
image

emilkrebs added 3 commits September 6, 2023 18:00
created a prewiew for domainmodel using d3.js

improved the tree layout

added visualisation for arrays

improved design

Signed-off-by: emilkrebs <[email protected]>

added error handling to domainmodel
@emilkrebs
Copy link
Contributor Author

Had to cherry-pick and create a new PR for eclipse ECA, here it is.

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested locally and the results look excellent, really happy with the visualization. There are a few little points regarding a typo & new line, but I would consider those non-blocking. With those in place it would be nice, but not required 🙂 .

hugo/assets/scripts/domainmodel/domainmodel-tools.ts Outdated Show resolved Hide resolved
hugo/assets/scripts/domainmodel/domainmodel-tools.ts Outdated Show resolved Hide resolved
hugo/assets/scripts/domainmodel/domainmodel-tools.ts Outdated Show resolved Hide resolved
@emilkrebs emilkrebs merged commit 0faf6ac into eclipse-langium:main Oct 13, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants