Dispose of Wrapper on Failed Start #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montymxb
force-pushed
the
montymxb/fix-wrapper-dispose
branch
from
4096dc2
to
b24315e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue with the recent playground changes, where a failed wrapper start was not disposing of the wrapper afterwards. This led to some strange behavior when working with grammars that would produce an invalid LS.
The solution here removes a previous workaround, and instead disposes of the wrapper in the appropriate place.
There is still a remaining issue with worker teardown, which does not succeed when the LC is stuck in a 'starting' state (see TypeFox/monaco-components#41). We're able to address this by first terminating the worker manually, then disposing the wrapper.
Note that the wrapper dispose will fail when the LC is stuck, but the teardown up to that point is sufficient to clean up the rest of the artifacts (editor & associated elements).