Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#194 Follow up and housekeeping #136

Merged
merged 2 commits into from
Jan 25, 2023
Merged

#194 Follow up and housekeeping #136

merged 2 commits into from
Jan 25, 2023

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Jan 20, 2023 •
edited
Loading

  • Follow-up of #194 Switch to peer dependencies for @theia dependencies #135: Align duplicate ws dependency version
  • Update eslint config to use dynamic year in headers
  • Re-generate yarn.lock to update several dependencies and resolve several dependabot alerts
  • Remove obsolete custom isAxiosError check and reuse built-in type check
  • Due to CI problems after Theia update: Increase pod resource limits

@ndoschek
#197 Follow up and housekeeping
3ef7bdb 
- Follow-up of #135: Align duplicate `ws` dependency version
- Update eslint config to use dynamic year in headers
- Re-generate yarn.lock to update several dependencies and resolve several dependabot alerts
- Remove obsolete custom isAxiosError check and reuse built-in type check
- Due to CI problems after Theia update: Increase pod resource limits
eneufeld
eneufeld requested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Found a small typo and added suggestions

.eslintrc.js Outdated Show resolved Hide resolved
packages/modelserver-client/package.json Outdated Show resolved Hide resolved
packages/modelserver-client/src/model-server-client-v2.ts Show resolved Hide resolved
This was referenced Jan 24, 2023
Open
Merged
eneufeld
eneufeld reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have a question about the header format which changed.

.eslintrc.js Show resolved Hide resolved
eneufeld
eneufeld approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ndoschek ndoschek merged commit e6ace1d into master Jan 25, 2023
@ndoschek ndoschek deleted the issues/197 branch January 25, 2023 15:20
@ndoschek ndoschek changed the title #197 Follow up and housekeeping #194 Follow up and housekeeping Feb 1, 2023
ndoschek added a commit that referenced this pull request Feb 1, 2023
@ndoschek
#194 Align ws version with @theia/core
975d397 
- Align the ws dependency version with Theia's version ^7.1.2
- The newer version (>8) seems to have breaking changes regarding the MessageEvent. This could not be serialized anymore onMessage notifications

Follow-up of #136
ndoschek added a commit that referenced this pull request Feb 1, 2023
@ndoschek
#194 Align ws dependency version with @theia/core
20f35cc 
- Align the ws dependency version with Theia's version ^7.1.2
- The newer version (>8) seems to have breaking changes regarding the MessageEvent. This could not be serialized anymore onMessage notifications
  - See also https://github.com/websockets/ws/releases/tag/8.0.0

Follow-up of #136
@ndoschek ndoschek mentioned this pull request Feb 1, 2023
Merged
ndoschek added a commit that referenced this pull request Feb 1, 2023
@ndoschek
#194 Align ws dependency version with @theia/core (#138)
5200d03 
- Align the ws dependency version with Theia's version ^7.1.2
- The newer version (>8) seems to have breaking changes regarding the MessageEvent. This could not be serialized anymore onMessage notifications
  - See also https://github.com/websockets/ws/releases/tag/8.0.0

Follow-up of #136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndoschek @eneufeld