Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jakartaee/faces#1999: default of jakarta.faces.STATE_SAVING_METHOD is actually "server" #5547

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Fix jakartaee/faces#1999: default of jakarta.faces.STATE_SAVING_METHOD is actually "server" #5547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions impl/src/main/java/com/sun/faces/renderkit/ResponseStateManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@

import java.io.IOException;

import com.sun.faces.renderkit.RenderKitUtils.PredefinedPostbackParameter;
import com.sun.faces.util.RequestStateManager;

import jakarta.faces.FacesException;
import jakarta.faces.annotation.FacesConfig.ContextParam;
import jakarta.faces.application.StateManager.StateSavingMethod;
import jakarta.faces.context.FacesContext;
import jakarta.faces.render.ResponseStateManager;

import com.sun.faces.renderkit.RenderKitUtils.PredefinedPostbackParameter;
import com.sun.faces.util.RequestStateManager;

/**
* <p>
* A <code>ResonseStateManager</code> implementation for the default HTML render kit.
Expand All @@ -38,7 +39,7 @@ public class ResponseStateManagerImpl extends ResponseStateManager {

public ResponseStateManagerImpl() {
FacesContext context = FacesContext.getCurrentInstance();
helper = ContextParam.STATE_SAVING_METHOD.isDefault(context) ? new ClientSideStateHelper() : new ServerSideStateHelper();
helper = ContextParam.STATE_SAVING_METHOD.getValue(context) == StateSavingMethod.CLIENT ? new ClientSideStateHelper() : new ServerSideStateHelper();
}

// --------------------------------------- Methods from ResponseStateManager
Expand Down
Loading