Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register to vscode-trace-extension as a trace server contributor #16

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

PatrickTasse
Copy link
Contributor

Activate the extension on the "onStartupFinished" activation event. At activation, register as a trace server contributor to the vscode-trace-extension, as the default wildcard contributor by not providing any isApplicable method implementation.

package.json Outdated
}
},
"extensionDependencies": [
"tracecompass-community.vscode-trace-extension"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use new publisher

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new publisher of the vscode-trace-extension is: eclipse-cdt which was changed in eclipse-cdt-cloud/vscode-trace-extension#191

Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rebase to latest main branch

Activate the extension on the "onStartupFinished" activation event. At
activation, register as a trace server contributor to the
vscode-trace-extension, as the default wildcard contributor by not
providing any isApplicable method implementation.

Signed-off-by: Patrick Tasse <[email protected]>
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks!

@PatrickTasse PatrickTasse merged commit bd538d7 into eclipse-cdt-cloud:main Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants