-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor story page to summary page #5732
Refactor story page to summary page #5732
Conversation
7c96a29
to
6608618
Compare
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
6608618
to
a6578ee
Compare
4c919fc
to
623eb97
Compare
…views # Conflicts: # print/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the lint warnings in the new code, then i will approve.
frontend/src/components/print/__tests__/repairPrintConfig.spec.js
Outdated
Show resolved
Hide resolved
@BacLuc strange, it somehow didn't complain when I linted locally in the container. |
Even if I understand the idea and can see the technical 'beauty' in it, I still wonder whether all our users understand the function. A few detailed questions:
|
We could still do this afterwards, if we see the need for it.
What context du you mean?
What bad could it do?
I don't understand what you mean. Can you give an example? |
Note sure. Migration from generic to concrete is not necessarily trivial.
In what case are 'all' notes meaningful without the other block information?
If we can't get rid of this print-block, we will have to be maintain forever.
Sorry, typo. |
Core Meeting Decision
|
This PR introduces the ability to filter ContentNodes and display them in an summary.
Solves #5067