materialItem: validate that quantity is greater than 0 #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
force-pushed
the
disallow-negative-numbers
branch
from
06c7f0d
to
d31b8bd
Compare
BacLuc
force-pushed
the
disallow-negative-numbers
branch
from
d31b8bd
to
0d235fe
Compare
pmattmann
approved these changes
Aug 4, 2024
simfeld
reviewed
Aug 6, 2024
| @@ -110,6 +110,7 @@ class MaterialItem extends BaseEntity implements BelongsToCampInterface, CopyFro | |||
| * The number of items or the amount in the unit of items that are required. | |||
| */ | |||
| #[ApiProperty(example: 1.5)] | |||
| #[Assert\GreaterThan(0)] | |||
There was a problem hiding this comment.
are there any implications for existing (now invalid) data?
There was a problem hiding this comment.
yes, existing values with invalid content cannot be saved anymore until you make a valid value out of it
| @@ -512,6 +512,7 @@ | |||
| "copied": "{source} kopiert" | |||
| }, | |||
| "validation": { | |||
| "greaterThan": "{_field_} muss grösser sein als {min}", | |||
There was a problem hiding this comment.
Looks not so great in the UI, can we improve this?
There was a problem hiding this comment.
This is a separate bug in firefox for all validations:
-> new issue
There was a problem hiding this comment.
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
usu
approved these changes
Aug 6, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5077