-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Checklist #5408
Feature: Checklist #5408
Conversation
f431137
to
a226da3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently while prototyping the frontend (#5460), I thought to myself if we probably need an (optional) numbering system for the checklist items, similar to the schedule entries? What do you think?
While trying to recreate the PBS checklist, I realized that 64 characters are not enough for checklist item texts, or then we need an additional description for longer texts.
Currently this is not a requirement.
I am happy to adapt this. How many characters should be supported? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thank you.
Some technicalities, most of which we could tackle later
api/tests/Api/ContentNodes/ChecklistNode/CreateChecklistNodeTest.php
Outdated
Show resolved
Hide resolved
59a361e
to
d080c5f
Compare
@BacLuc |
233b47d
to
f0067ea
Compare
api/tests/Api/ContentNodes/ChecklistNode/UpdateChecklistNodeTest.php
Outdated
Show resolved
Hide resolved
api/tests/Api/ContentNodes/ChecklistNode/UpdateChecklistNodeTest.php
Outdated
Show resolved
Hide resolved
api/tests/Api/ContentNodes/ChecklistNode/UpdateChecklistNodeTest.php
Outdated
Show resolved
Hide resolved
api/tests/Api/ContentNodes/ChecklistNode/UpdateChecklistNodeTest.php
Outdated
Show resolved
Hide resolved
don't wait for this. |
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much
f00c661
to
5f73b07
Compare
5f73b07
to
a038b22
Compare
fix unittest
5cf86d5
to
137bd60
Compare
I would merge the backend early so that the two frontend components can be developed at the same time.
Relates to #4936