fixes according to review

ecamp · Jul 9, 2024 · 6af1f65 · 6af1f65
1 parent e0f65ff
commit 6af1f65
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/api/fixtures/checklistItems.yml b/api/fixtures/checklistItems.yml
@@ -9,9 +9,6 @@ App\Entity\ChecklistItem:
     checklist: '@checklist1'
     parent: '@checklistItem1_1_2'
     text: 'Camp1_List1_Item2_Item3'
-# checklist2WithNoItems:
-#   checklist: '@checklist2WithNoItems'
-#   text: 'Camp1_List2_Item1'
   checklistItem2_1_1:
     checklist: '@checklist1camp2'
     text: 'Camp2_List1_Item1'

diff --git a/api/migrations/schema/Version20240620143000.php b/api/migrations/schema/Version20240620143000.php
@@ -29,6 +29,6 @@ public function up(Schema $schema): void {
 
     public function down(Schema $schema): void {
         // this down() migration is auto-generated, please modify it to your needs
-        $this->addSql('DELETE FROM public.content_type WHERE id IN (\'a4211c11211c\')');
+        $this->addSql("DELETE FROM public.content_type WHERE id IN ('a4211c11211c')");
     }
 }
diff --git a/api/src/Entity/Checklist.php b/api/src/Entity/Checklist.php
@@ -102,7 +102,7 @@ class Checklist extends BaseEntity implements BelongsToCampInterface, CopyFromPr
     #[Assert\NotBlank]
     #[Assert\Length(max: 32)]
     #[ORM\Column(type: 'text')]
-    public ?string $name = null;
+    public string $name;
 
     public function __construct() {
         parent::__construct();