Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make classes upper case again #298

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

Funth0mas
Copy link
Contributor

When merging the 'typing' branch I realized that some classes was unwillingly refactored to snake case.

@ebroecker
Copy link
Owner

... what do you think, should classes be snake_case or camelCase?
I don't know.
We only discussed lossely in #236 to switch to snake_case.

In all cases, you are right, its not consistent as is now.

@altendky
Copy link
Collaborator

UpperCamel is what pep8 suggests for normal situations.

https://www.python.org/dev/peps/pep-0008/#class-names

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #298 into development will not change coverage.
The diff coverage is 78.26%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #298   +/-   ##
============================================
  Coverage        37.81%   37.81%           
============================================
  Files               34       34           
  Lines             6820     6820           
  Branches          1675     1675           
============================================
  Hits              2579     2579           
  Misses            4023     4023           
  Partials           218      218
Impacted Files Coverage Δ
src/canmatrix/xls.py 10.58% <0%> (ø) ⬆️
src/canmatrix/kcd.py 5.05% <0%> (ø) ⬆️
src/canmatrix/xlsx.py 1.05% <0%> (ø) ⬆️
src/canmatrix/dbf.py 4.22% <0%> (ø) ⬆️
src/canmatrix/canmatrix.py 71.87% <100%> (ø) ⬆️
src/canmatrix/dbc.py 50.07% <100%> (ø) ⬆️
src/canmatrix/tests/test_canmatrix.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a7832...dcd0894. Read the comment docs.

Copy link
Owner

@ebroecker ebroecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again

@ebroecker ebroecker merged commit a303dff into ebroecker:development Feb 26, 2019
@Funth0mas Funth0mas deleted the fix_class_names branch February 26, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants