-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-house processing of marginaleffects objects #1063
Comments
We should probably submit bayestestR (easystats/bayestestR#691) the next days, then we should have the basis for this PR. |
By daniel here about modelbased:
I'm all for outsourcing its postprocessing to parameters, this feels like the right place to have it. So I'd move the postprocessing from modelbased to here and have modelbased call parameters(). |
Agree. But I think we can wait for 1.0.0 release to do this (both parameters and marginaleffects) |
I suggest, wherever the method is, to use the |
Yes, I would call tidy() for frequentist models, because this is maintained in marginaleffects. And for Bayesian models, we call describe_posterior() instead. |
Currently we call the
tidy()
function,parameters/R/methods_marginaleffects.R
Lines 12 to 15 in 804cfcb
which is defined here: https://github.com/vincentarelbundock/marginaleffects/blob/a6730a3560dbf4220d4bf82da141400fa235b996/sandbox/tidy_old.R#L92
But this strongly limits our capabilities (especially in Bayesian cases). We should probably not rely on
tidy
and reimplement it usingbayestestR
for the processing of draws.easystats/modelbased#302
The text was updated successfully, but these errors were encountered: