Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary.estimate_slopes() no longer working. #345

Open
Tracked by #289
strengejacke opened this issue Jan 16, 2025 · 5 comments · May be fixed by #371
Open
Tracked by #289

summary.estimate_slopes() no longer working. #345

strengejacke opened this issue Jan 16, 2025 · 5 comments · May be fixed by #371
Assignees
Labels
Bug 🐛 Something isn't working
Milestone

Comments

@strengejacke
Copy link
Member

m <- lm(Sepal.Width ~ Sepal.Length, data = iris)
modelbased::estimate_slopes(m, trend = "Sepal.Length", backend = "marginaleffects") |> summary()
#> Error in if ((data$Confidence[i] != sig) || ((centrality_signs[i] != centrality_sign) && : missing value where TRUE/FALSE needed

Created on 2025-01-16 with reprex v2.1.1

@strengejacke strengejacke added the Bug 🐛 Something isn't working label Jan 16, 2025
@DominiqueMakowski
Copy link
Member

DominiqueMakowski commented Jan 16, 2025

Ah yes, I should have seen that coming

This is blocked by easystats/parameters#1063

Basically, summary.estimate_slopes() will create "segments" of similar slope (negative, positive, flat) based on coef sign and significance. Since we don't have significance with marginaleffects yet...

Either we fix the above, OR another option would be that in the absence of indices of significance, we only use the sign of the coefficient to make the groups

@strengejacke
Copy link
Member Author

estimate_contrasts() returns p values also for slopes... Or we use the CI

@DominiqueMakowski
Copy link
Member

image

The people have spoken on the most desired easystats feature 🫡

@strengejacke
Copy link
Member Author

Which comment?

@DominiqueMakowski
Copy link
Member

@strengejacke strengejacke self-assigned this Jan 29, 2025
@strengejacke strengejacke added this to the 1.0.0 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants