Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

describe_posterior() only conditionally calls rope_range() when needed #695

Merged
merged 2 commits into from
Jan 28, 2025
Merged

describe_posterior() only conditionally calls rope_range() when needed #695

merged 2 commits into from
Jan 28, 2025

Conversation

mattansb
Copy link
Member

Partially address easystats/insight#997

@mattansb mattansb mentioned this pull request Jan 27, 2025
Open
@mattansb mattansb requested a review from strengejacke January 27, 2025 09:55
@strengejacke
Copy link
Member

Looks good! As mentioned in easystats/insight#997 (comment), I'd also add no_recursion = TRUE to all get_sigma() calls.

@mattansb mattansb merged commit 00183b2 into main Jan 28, 2025
18 of 22 checks passed
@mattansb mattansb deleted the selective-rope_range branch January 28, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strengejacke strengejacke Awaiting requested review from strengejacke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattansb @strengejacke