Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(editor): hide topbar config #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maarten2424
Copy link
Contributor

Description

Hide the topbar when hideTopBar is set to true in the easyblocks config

Copy link

vercel bot commented Mar 20, 2024

@maarten2424 is attempting to deploy a commit to the Shopstory Team on Vercel.

A member of the Team first needs to authorize it.

@r00dY
Copy link
Contributor

r00dY commented Apr 10, 2024

@maarten2424 I think it's a great idea. We got quite a lot of requests for such feature, namely more control over the top bar. However, I feel that just adding hideTopBar flag is a bit simplistic. It indeed hides the top bar but also doesn't allow devs to control over switching breakpoints, enabling / disabling edit mode, calling undo / redo actions etc. This control should be passed to devs when top bar is hidden imo. Thoughts?

@maarten2424
Copy link
Contributor Author

@r00dY with the latest postMessage MR, i'm including events to set fire the header actions. Should we also include functions to the easyblocks editor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants