BBS+: add some checks on disclosed indexes array #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
ahah!! so you read my email and blog !!!! <3 thanks a lot for taking the initiative !!! 👍🏽 |
jaromil
reviewed
Oct 15, 2024
src/lua/crypto_bbs.lua
Outdated
| local disclosed_messages = {} | ||
| local undisclosed_messages = {} | ||
| for i, v in ipairs(disclosed_indexes) do | ||
| if i > 1 and disclosed_indexes[i] == disclosed_indexes[i - 1] then |
There was a problem hiding this comment.
I am not sure that checking only adjacent values suffices here. There can be scattered duplicates.
There was a problem hiding this comment.
Arrays are always sorted in proof_gen (line 684) before being passed as input to core_proof_gen
There was a problem hiding this comment.
can you add this sentence as comment in that line of code?
jaromil
reviewed
Oct 15, 2024
src/lua/crypto_bbs.lua
Outdated
| @@ -679,6 +682,7 @@ function bbs.proof_gen(ciphersuite, pk, signature, header, ph, messages, disclos | |||
| header = header or O.empty() | |||
| ph = ph or O.empty() | |||
| table.sort(disclosed_indexes) -- make sure indexes are sorted | |||
| if (disclosed_indexes[1] <= 0 or disclosed_indexes[#disclosed_indexes] > #messages) then error('disclosed indexes contains not valid integers', 2) end | |||
There was a problem hiding this comment.
It is best to separate this check in two and give a more accurate error message describing the cause.
|
many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.