Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove yarn from javascript dependencies #937

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

matteo-cristino
Copy link
Collaborator

  • chore: remove yarn from javascript dependencies
  • ci(js): remove cwd since working directory is already set to the right folder

chore(ci): make working dir always root of zenroom
@jaromil
Copy link
Member

jaromil commented Oct 7, 2024

I've changed the way this PR works by keeping the workdir at root in CI and keeping --cwd

This way it will be aligned with the new makefile system which will also use --cwd

@jaromil jaromil merged commit 8e11593 into master Oct 8, 2024
26 checks passed
@jaromil jaromil deleted the chore/js branch October 8, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants