Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better enforcement on dymint flags #377

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner June 28, 2023 09:13
@mtsitrin mtsitrin linked an issue Jun 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #377 (464972c) into main (a6e92dc) will decrease coverage by 1.24%.
The diff coverage is 34.58%.

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   52.17%   50.94%   -1.24%     
==========================================
  Files          90       92       +2     
  Lines       14259    14299      +40     
==========================================
- Hits         7440     7284     -156     
- Misses       5778     5997     +219     
+ Partials     1041     1018      -23     
Impacted Files Coverage Δ
block/manager.go 69.55% <ø> (-0.28%) ⬇️
settlement/config.go 0.00% <0.00%> (ø)
testutil/block.go 100.00% <ø> (ø)
config/config.go 32.20% <18.51%> (-7.22%) ⬇️
config/flags.go 33.33% <33.33%> (ø)
node/testutils.go 89.28% <100.00%> (+2.32%) ⬆️
testutil/types.go 75.14% <100.00%> (+1.17%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtsitrin mtsitrin closed this Jun 28, 2023
@mtsitrin mtsitrin reopened this Jun 28, 2023
@omritoptix
Copy link
Contributor

@mtsitrin build failed

@omritoptix omritoptix merged commit cc439f3 into main Jun 29, 2023
@omritoptix omritoptix deleted the dymint/119-better-enforcement-on-dymint-flags branch June 29, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better enforcement on dymint flags
2 participants