Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and add test for invalid vaults. (backport #2535) #2536

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 22, 2024

Changelist

Had a typo when returning valid/invalid vaults. Updated a test to catch this.

Test Plan

Unit test.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Enhanced API functionality to handle multiple vault subaccounts, including validation for invalid entries.
  • Bug Fixes

    • Improved data integrity by filtering vault mappings to include only those corresponding to valid perpetual markets.
  • Tests

    • Added a new test case for scenarios involving two vault subaccounts, one being invalid, to ensure correct API behavior.

This is an automatic backport of pull request #2535 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 22, 2024 20:09
@mergify mergify bot mentioned this pull request Oct 22, 2024
6 tasks
@vincentwschau vincentwschau merged commit 38a2d36 into release/indexer/v7.x Oct 22, 2024
16 checks passed
@vincentwschau vincentwschau deleted the mergify/bp/release/indexer/v7.x/pr-2535 branch October 22, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant