Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't increment messageId for custom ping messages (backport #2493) #2497

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2024

Changelist

don't increment messageId for custom ping messages

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • Bug Fixes

    • Improved handling of message IDs for subscription and unsubscription processes, ensuring accurate tracking of messages.
    • Added checks for active connections to prevent operations on closed connections.
  • Chores

    • Updated logging statements for better clarity on subscription and unsubscription activities.

This is an automatic backport of pull request #2493 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 16, 2024 15:26
@dydxwill dydxwill merged commit 666898f into release/indexer/v7.x Oct 16, 2024
15 checks passed
@dydxwill dydxwill deleted the mergify/bp/release/indexer/v7.x/pr-2493 branch October 16, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant