Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-629] Fix entryPrice calc (backport #2455) #2496

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[CT-629] Fix entryPrice calc (backport #2455) #2496

merged 1 commit into from
Oct 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2024

Summary by CodeRabbit

  • Bug Fixes

    • Adjusted test cases for LiquidationHandler and OrderHandler to reflect changes in the defaultPerpetualPosition size, ensuring accurate validation of liquidation orders and order fills.
    • Updated calculations in tests to align with the new expected values for sumOpen and position size.

  • Chores

    • Refined SQL functions for handling entry price calculations, improving accuracy in order fill processing and perpetual position updates.
    • Enhanced test suite by adding new scenarios for order fills, ensuring thorough validation of order handling logic.
This is an automatic backport of pull request #2455 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 16, 2024 15:23
@mergify mergify bot mentioned this pull request Oct 16, 2024
Merged
@linear Linear
Copy link

linear bot commented Oct 16, 2024

CT-629 BE does not calculate average entry price correctly.

@dydxwill dydxwill merged commit 54b3bce into release/indexer/v7.x Oct 16, 2024
16 checks passed
@dydxwill dydxwill deleted the mergify/bp/release/indexer/v7.x/pr-2455 branch October 16, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dydxwill dydxwill dydxwill approved these changes

Assignees

@dydxwill dydxwill

Labels
indexer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dydxwill