Fix mock generation, remove AssetsKepeer mock.

[vincentwschau]

Changelist

The mock is not used and there is no type for the mock.

Test Plan

N/A

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• Chores
  • Removed the autogenerated mock implementation for the AssetsKeeper type, streamlining testing processes.
  • Deleted the command for generating the AssetsKeeper mock from the project’s build configuration.

[coderabbitai]

Walkthrough

The changes in this pull request involve the removal of the AssetsKeeper.go mock implementation and its associated mock generation command from the Makefile. The AssetsKeeper.go file, previously used for unit testing by simulating the behavior of the AssetsKeeper type, has been deleted. Consequently, the command responsible for generating this mock has also been removed from the Makefile, indicating that the AssetsKeeper interface will no longer have a mock representation in the project.

Changes

File	Change Summary
protocol/mocks/AssetsKeeper.go	Deleted the entire file, which included mock methods for AssetsKeeper, facilitating unit testing without real implementations.
protocol/mocks/Makefile	Removed the command that generates the mock for the AssetsKeeper interface, indicating no further mock generation for this type.

Possibly related PRs

• [Fix test flakiness due to using inconsistent time. #2485] Fix test flakiness due to using inconsistent time: This PR addresses issues related to test stability by ensuring that time calculations align with the start of the hour, which is relevant to the changes made in the main PR regarding the AssetsKeeper mock functions that also deal with time-sensitive operations.

🐇 In the meadow, the changes take flight,
No more mocks for the AssetsKeeper's might.
With a hop and a skip, we clear the way,
For simpler tests in the light of day.
Goodbye to the mock, hello to the real,
In our coding garden, we spin the wheel! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9449952 and ec8f8ca.

📒 Files selected for processing (2)

• protocol/mocks/AssetsKeeper.go (0 hunks)
• protocol/mocks/Makefile (0 hunks)

💤 Files with no reviewable changes (2)

• protocol/mocks/AssetsKeeper.go
• protocol/mocks/Makefile

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.