Fixing strdup() compilation warning (not ISO C) #309

dvorka · Aug 26, 2018 · d9f190c · d9f190c
1 parent 1ebc0c1
commit d9f190c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/hstr_history.c b/src/hstr_history.c
@@ -55,7 +55,7 @@ char* get_history_file_name(void)
     } else {
         // allocate so that this function always returns string to be freed
         // (getenv() returns pointer (no need to free), home is allocated (must be freed)
-        historyFile = strdup(historyFile);
+        historyFile = hstr_strdup(historyFile);
     }
     return historyFile;
 }
@@ -155,7 +155,7 @@ HistoryItems* prioritized_history_create(int optionBigKeys, HashSet *blacklist)
             if((r=hashset_get(&rankmap, line))==NULL) {
                 r=malloc(sizeof(RankedHistoryItem));
                 r->rank=history_ranking_function(0, i, strlen(line));
-                r->item=strdup(line);
+                r->item=hstr_strdup(line);
 
                 hashset_put(&rankmap, line, r);
 

diff --git a/src/include/hstr_history.h b/src/include/hstr_history.h
@@ -21,7 +21,6 @@
 
 #include <fcntl.h>
 #include <limits.h>
-#include <string.h>
 // do NOT remove stdio.h include - must be present on certain system before readline to compile
 #include <stdio.h>
 #include <readline/history.h>