Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 #139

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Support Python 3.13 #139

merged 4 commits into from
Nov 17, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Aug 21, 2024

@edgarrmondragon
Copy link
Contributor Author

@dvarrazzo let me know if you'd like to see something else in this PR or if it's good to merge 😄

@dvarrazzo
Copy link
Owner

Hello, thank you for this!

I am sorry, this MR skipped under the radar. I don't have a lot of bandwidth right now, but I will try to take a look at it!

@edgarrmondragon
Copy link
Contributor Author

ping @dvarrazzo 🙏

@dvarrazzo
Copy link
Owner

Trying a build. If it passes I'll release the package.

Thank you very much!

Copy link
Contributor Author

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems cibw is still trying to build pp37 wheels

.github/workflows/packages.yml Show resolved Hide resolved
.github/workflows/packages.yml Show resolved Hide resolved
@edgarrmondragon
Copy link
Contributor Author

Wheel builds are passing on my fork: https://github.com/edgarrmondragon/py-setproctitle/actions/runs/11860299695/job/33064232120.

But there's a failure in the macos-native-python-test job: https://github.com/dvarrazzo/py-setproctitle/actions/runs/11860296122/job/33055225047?pr=139. I might not have time to look at it today.

@dvarrazzo
Copy link
Owner

Everything seems passing for me. I had already fixed the leftover 3.7 builds in my branch.

I have also added a merge step to download together all the artifacts and bumped package version numbers. Force-pushing here in order to merge the MR leaving the attribution of your changesets.

@edgarrmondragon
Copy link
Contributor Author

Nice, thanks @dvarrazzo!

@dvarrazzo dvarrazzo merged commit 39159bf into dvarrazzo:master Nov 17, 2024
92 checks passed
@dvarrazzo
Copy link
Owner

setproctitle 1.3.4 released, with Python 3.13 support added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants