Add error reporting to progress report API call #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vegarsti
force-pushed
the
report-errors-to-dune
branch
from
59469d3 to
594d404
Compare
vegarsti
force-pushed
the
report-errors-to-dune
branch
from
594d404 to
8afe1e0
Compare
|
I'm merging this so that I can build and push to DockerHub |
msf
reviewed
Jun 29, 2024
| @@ -214,7 +214,7 @@ func (c *client) Close() error { | |||
| } | |||
|
|
|||
| func (c *client) PostProgressReport(ctx context.Context, progress models.BlockchainIndexProgress) error { | |||
There was a problem hiding this comment.
when we complete this, we need to reset to zero the errors that we have aggregated so far.
otherwise at some point we'll have an OOM due to accumulated errors in memory.
this must be treated as an optimistic behavior, there will be errors we never capture (we hard crash), so we shouldn't be pedantic, we should really (try to) report and reset the errors we have.
There was a problem hiding this comment.
but we do!
node-indexer/ingester/mainloop.go
Lines 226 to 228 in 8afe1e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so we collect errors and send them to Dune as part of the progress report request.
I added two models in this PR, one in the
modelspackage and one in the DuneAPI package. This means we have three structs for representing the same kind of error (there's also one in `ingester). Is that too much? 😅