Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mainloop: simplify the trySendCompletedBlocks #43

Merged
merged 2 commits into from
Jun 27, 2024
Merged

mainloop: simplify the trySendCompletedBlocks #43

merged 2 commits into from
Jun 27, 2024

Conversation

msf
Copy link
Contributor

@msf msf commented Jun 27, 2024

also, increase throughput by avoiding very small batches

@msf msf requested a review from vegarsti June 27, 2024 13:53
Copy link
Member

@vegarsti vegarsti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

ingester/mainloop.go Outdated Show resolved Hide resolved
@msf msf force-pushed the more-tweaks branch 2 times, most recently from 35c9017 to b3422e1 Compare June 27, 2024 14:06
default RPCConcurrency to 25
also, increase throughput by avoiding very small batches
@msf msf merged commit 68b10f4 into main Jun 27, 2024
1 check passed
@vegarsti vegarsti deleted the more-tweaks branch June 28, 2024 05:48
Comment on lines -174 to +175
for _, n := range []int64{2, 3, 4, 5, 10} {
// NOTE: this size and maxBatchSize are related, because we optimize for not sending tiny batches
for _, n := range []int64{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 19} {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants