Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements in mainloop.go #34

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Some improvements in mainloop.go #34

merged 1 commit into from
Jun 24, 2024

Conversation

vegarsti
Copy link
Member

@vegarsti vegarsti commented Jun 22, 2024

Implements some useful suggestion from @msf #32

  • ConsumeBlocks -> FetchBlockLoop
  • Extract trySendCompletedBlocks from SendBlocks

@vegarsti vegarsti requested a review from msf June 22, 2024 05:17
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vegarsti and the rest of your teammates on Graphite Graphite

@vegarsti vegarsti force-pushed the naming-improvements branch from e008041 to c768a8f Compare June 22, 2024 05:19
@vegarsti vegarsti changed the title Some naming improvements in mainloop.go Some improvements in mainloop.go Jun 22, 2024
@vegarsti vegarsti force-pushed the naming-improvements branch 3 times, most recently from 46c404c to 9a8694d Compare June 24, 2024 04:50
@vegarsti vegarsti force-pushed the naming-improvements branch from 9a8694d to cff69ca Compare June 24, 2024 05:14
@vegarsti vegarsti merged commit d83f853 into main Jun 24, 2024
1 check passed
@vegarsti vegarsti deleted the naming-improvements branch June 24, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant