Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the OmnibarLayout crash #5182

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix the OmnibarLayout crash #5182

merged 1 commit into from
Oct 24, 2024

Conversation

0nko
Copy link
Member

@0nko 0nko commented Oct 24, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1208618045189439/f

Description

We need to make sure all attempts to access the OmnibarLayout’s ViewModel are checked to make sure the window is attached, otherwise the view may not be injected yet.

Steps to test this PR

  • Enable Don’t keep activities option in Developer options
  • Clear the app storage and start the app
  • Go through the flow until the omnibar is visible
  • Switch to a different app
  • Come back to the app
  • Notice the app doesn’t crash
  • Go to settings and change the omnibar position
  • Navigate back to the browser
  • Notice the app doesn’t crash

@0nko 0nko requested a review from malmstein October 24, 2024 11:55
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@0nko 0nko merged commit ad99cff into develop Oct 24, 2024
7 checks passed
@0nko 0nko deleted the fix/ondrej/omnibar-layout-crash branch October 24, 2024 12:11
@malmstein malmstein self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants