-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate favorites grid pixel based on origen #5153
Differentiate favorites grid pixel based on origen #5153
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on Graphite |
ef742b1
to
e5c10a0
Compare
FOCUSED_STATE, | ||
NEW_TAB_PAGE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Could give each enum an int value and then use that in FavouritesNewTabSectionView
as NEW_TAB_PAGE
instead of 1
e5c10a0
to
79027ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢🇮🇹
Thanks @mikescamell ! |
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208571301207064
Description
This PR differentiates pixels launched from the Favorites view. As of now, they can come from Focused state or New Tab Page.
Steps to test this PR
Start with a fresh app install, otherwise daily pixels won’t fire properly
Focused state
m_edit_favourite_dialog_shown
is firedm_edit_favourite_dialog_shown_daily
is firedm_favorite_removed
is firedm_favorite_deleted
is firedm_favorite_clicked_focused_state
is firedm_favorite_clicked_focused_state_daily
is firedNew Tab
m_edit_favourite_dialog_shown
is firedm_edit_favourite_dialog_shown_daily
is firedm_favorite_removed
is firedm_favorite_deleted
is firedm_favorite_clicked_new_tab_page
is firedm_favorite_clicked_new_tab_page_daily
is fired