Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate favorites grid pixel based on origen #5153

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Oct 18, 2024

Task/Issue URL: https://app.asana.com/0/1174433894299346/1208571301207064

Description

This PR differentiates pixels launched from the Favorites view. As of now, they can come from Focused state or New Tab Page.

Steps to test this PR

Start with a fresh app install, otherwise daily pixels won’t fire properly

Focused state

  • Open an app and add a favorite
  • Tap on the omnibar so the focused state view appears
  • Long press on the favorite
  • Tap on Edit
  • Verify m_edit_favourite_dialog_shown is fired
  • Verify m_edit_favourite_dialog_shown_daily is fired
  • Go back and long press again
  • Tap on Remove and wait for the snackbar to disappear
  • Verify m_favorite_removed is fired
  • Add the same favourite again and open focused state again
  • Long press favourite, tap on Delete and wait for the snackbar to disappear
  • Verify m_favorite_deleted is fired
  • Add the same favourite again and open focused state again
  • Tap on the favorite
  • Verify m_favorite_clicked_focused_state is fired
  • Verify m_favorite_clicked_focused_state_daily is fired

New Tab

  • Open an app and add a favorite
  • Open New Tab
  • Long press on the favorite
  • Tap on Edit
  • Verify m_edit_favourite_dialog_shown is fired
  • Verify m_edit_favourite_dialog_shown_daily is fired
  • Go back and long press again
  • Tap on Remove and wait for the snackbar to disappear
  • Verify m_favorite_removed is fired
  • Add the same favourite again and open focused state again
  • Long press favourite, tap on Delete and wait for the snackbar to disappear
  • Verify m_favorite_deleted is fired
  • Add the same favourite again and open focused state again
  • Tap on the favorite
  • Verify m_favorite_clicked_new_tab_page is fired
  • Verify m_favorite_clicked_new_tab_page_daily is fired

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite Graphite

@malmstein malmstein marked this pull request as ready for review October 21, 2024 08:06
@malmstein malmstein force-pushed the feature/david/10-18-differentiate_favorites_grid_pixel_based_on_origen branch 2 times, most recently from ef742b1 to e5c10a0 Compare October 21, 2024 11:36
@mikescamell mikescamell self-assigned this Oct 21, 2024
Comment on lines +75 to +76
FOCUSED_STATE,
NEW_TAB_PAGE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Could give each enum an int value and then use that in FavouritesNewTabSectionView as NEW_TAB_PAGE instead of 1

@malmstein malmstein force-pushed the feature/david/10-18-differentiate_favorites_grid_pixel_based_on_origen branch from e5c10a0 to 79027ce Compare October 22, 2024 08:04
Copy link
Contributor

@mikescamell mikescamell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢🇮🇹

@malmstein
Copy link
Contributor Author

Thanks @mikescamell !

@malmstein malmstein merged commit 2255576 into develop Oct 22, 2024
7 checks passed
@malmstein malmstein deleted the feature/david/10-18-differentiate_favorites_grid_pixel_based_on_origen branch October 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants