Remove the extra gap during onboarding #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208267346828963/f ### Description Adds a new DaxBubbleCardViewExperiment for upcoming experiment with onboarding. These are not visible will be used later in another task. To see these dialogs they will need to be enabled in code. ### Steps to test this PR _Launch onboarding_ - [ ] Ensure dialog shape and arrows have not changed ### UI changes There should be none. But here are examples of what the dialogs should look like when shown:   
…e bottom to show the button
nalcalag
force-pushed
the
feature/noelia/highlights_pre_onboarding
branch
from
404a508
to
0355839
Compare
…ej/onboarding_gap # Conflicts: # app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt # app/src/main/java/com/duckduckgo/app/browser/omnibar/TopAppBarBehavior.kt # app/src/main/res/layout/include_new_browser_tab.xml
nalcalag
approved these changes
Oct 22, 2024
0nko
merged commit ad24b48
into
feature/noelia/highlights_pre_onboarding
5 checks passed
nalcalag
added a commit
that referenced
this pull request
Oct 22, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208542610603557/f ### Description This PR removes the extra gap that was visible during onboarding. The issue was mainly caused by [this](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-38c52e4c3d2d7891eed9656823f30c41a4984cdeaa5f89a78e31f57340f6afbeL39). Removing it, however, had a cascading side effect: - A [behavior](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-38c52e4c3d2d7891eed9656823f30c41a4984cdeaa5f89a78e31f57340f6afbeR25) had to be added to the new browser tab layout so that the NTP content would stay below the address bar now that the padding was removed - The change above, caused some new layout changes, for example the button on the NTP was now out of the viewport, so a bottom margin [had to be added](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-38c52e4c3d2d7891eed9656823f30c41a4984cdeaa5f89a78e31f57340f6afbeR45) - The change above had a side effect that an unwanted gap was added to the browser view during the partial onboarding, so some logic had to be added bot to the [bottom](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-fe6ebde9b11eddd212b40d9b12701a7e23e083cfc919c06b7a084d8f3e61154dR60) and [top](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-f5d61424e875a30ac1059375679a3bebb00e754e93a33f01d026019618bea1c0R45-R48) bar behavior ### Steps to test this PR _The toolbar is at the **top**_ - [x] Test the entire onboarding flow with the bar at the top and verify no unwanted gaps are present - [x] Test that the NTP looks correct, with the Edit button visible at the bottom - [x] Test the autocomplete list is scrollable and all items are visible - [x] Test that browser layout looks correct with no unwanted gaps _The toolbar is at the **bottom**_ - [x] Test the entire onboarding flow with the bar at the top and verify no unwanted gaps are present - [x] Test that the NTP looks correct, with the Edit button visible at the bottom - [x] Test the autocomplete list is scrollable and all items are visible - [x] Test that browser layout looks correct with no unwanted gaps --------- Co-authored-by: Noelia Alcala <[email protected]> Co-authored-by: Mike Scamell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208542610603557/f
Description
This PR removes the extra gap that was visible during onboarding. The issue was mainly caused by this. Removing it, however, had a cascading side effect:
Steps to test this PR
The toolbar is at the top
The toolbar is at the bottom