Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid location permission messages for Duck AI #5140

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Oct 15, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1208539436428546/f

Description

This PR avoids showing the location permission snackbar when user is in AI Chat

Steps to test this PR

Enable location permission from SERP

  • Open app and search for restaurants near me
  • When prompted, allow for location permission ALWAYS
  • Close the app

Duck AI directly

  • navigate to duck.ai
  • verify that location snackbar doesn’t appear
  • Close the app

AI Chat via SERP

  • navigate to serp and open Duck AI from the SERP toolbar
  • verify that location snackbar doesn’t appear

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite Graphite

@malmstein malmstein changed the title Avoid location permission messages for AI Chat Avoid location permission messages for Duck AI Oct 15, 2024
@malmstein malmstein marked this pull request as ready for review October 15, 2024 15:06
@malmstein malmstein force-pushed the feature/david/10-15-avoid_location_permission_messages_for_ai_chat branch from 8a7527f to 9367e35 Compare October 16, 2024 08:19
@0nko 0nko self-requested a review October 16, 2024 08:25
Copy link
Member

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. :shipit:

@malmstein malmstein merged commit 57356a3 into develop Oct 16, 2024
6 checks passed
@malmstein malmstein deleted the feature/david/10-15-avoid_location_permission_messages_for_ai_chat branch October 16, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants