Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlights Onboarding Experiment #5116

Merged
merged 26 commits into from
Oct 23, 2024

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Oct 9, 2024

Task/Issue URL: https://app.asana.com/0/1201807753394693/1208486644029037/f

Description

Implement Highlights Experiment on Android

Steps to test this PR

Pre steps

Pre onboarding

  • Fresh install
  • Check background is updated to experiment assets
  • Check Dax dialogs UI is updated (new radius and edge)
  • Tap on "Let's do it"
  • Check comparison chart has new icons for each chart item
  • Check copy is updated
  • Tap on "Choose Your Browser" (doesn't matter if you set DDG as default or not)
  • Check new address bar position dialog appear
  • Check new pixel m_preonboarding_address_bar_position_dialog_shown_unique is fired
  • Tap on Bottom option
  • Tap on "Next"
  • Check new pixel m_preonboarding_bottom_address_bar_selected_unique is fired
    ...

Try a search Dax dialog

  • Check new "Try a search" dialog appear with updated UI (background, radius and edge)
  • Check dialog's copy is updated
  • Check there are only 3 search options
  • Tap on Surprise me! option
  • Check you navigate to baby ducklings search
    ...

SERP Dax dialog

  • Check updated SERP dialog is displayed
  • Check pixel m_odc_s is fired with parameter cta = s
  • Tap on a "Got it!"
    ...

Site suggestions Dax dialog

  • Check updated Site Suggestions dialog is displayed
  • Check pixel m_odc_s is fired with parameter cta = visit_site
  • Tap on any site suggestion
    ...

Trackers Blocked Dax dialog

  • Check updated Trackers blocked Dax dialog is displayed
  • Check privacy shield is highlighted
  • Check pixel m_odc_s is fired with parameter cta = t
  • Tap on privacy shield
  • Go back to browser
  • Check highlight is gone
  • Tap on Got it! button
    ...

Fire Button Dax dialog

  • Check updated Fire Dax dialog with 2 buttons is displayed
  • Check pixel m_odc_s is fired with parameter cta = fd
  • Check fire button highlight is on
  • Tap on fire button
  • Check dialog is dismissed
  • Check fire button highlight is off
  • Tap on Clear Data
    ...

End onboarding dialog

  • Check updated end Dax dialog is shown in new tab

Fire Dax dialog 'Skip' button

  • Fresh install
  • Repeat all steps until seeing Fire Dax dialog again
  • Tap on 'Skip' secondary button
  • Check pixel m_onboarding_dax_cta_cancel is fired with parameter cta = fd
  • Check updated End dialog appear
  • Check pixel m_odc_s is fired with parameter cta = end

Fire Dax dialog 'Try it' button

  • Fresh install
  • Repeat all steps until seeing Fire Dax dialog again
  • Tap on 'Try it' secondary button
  • Check pixel m_odc_ok is fired with parameter cta = fd
  • Check Fire button options are displayed and highlight is removed
  • Tap on Cancel
  • Check Fire dialog has been dismissed
  • Check updated End dialog appear
  • Refresh site
  • Check updated End Dax dialog is displayed
  • Check pixel m_odc_s is fired with parameter cta = end

No Trackers Dax dialog

  • Fresh install
  • Go to wikipedia.org
  • Check no trackers Dax dialog has the new UI
  • Check pixel m_odc_s is fired with parameter cta = nt
    ...

Trackers Network Dax dialog

  • Go to facebook.com
  • Check network Dax dialog has the new UI
  • Check pixel m_odc_s is fired with parameter cta = n
    ...

UI changes

Before After

|

|

@nalcalag
Copy link
Contributor Author

nalcalag commented Oct 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on Graphite Graphite

@nalcalag nalcalag force-pushed the feature/noelia/highlights_pre_onboarding branch 2 times, most recently from 5f1f36e to cf30363 Compare October 9, 2024 14:44
@nalcalag nalcalag marked this pull request as ready for review October 10, 2024 13:24
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments added in Asana but otherwise LGTM

@nalcalag nalcalag force-pushed the feature/noelia/highlights_pre_onboarding branch from 66b721a to 1cdddac Compare October 14, 2024 15:38
@nalcalag nalcalag force-pushed the feature/noelia/highlights_pre_onboarding branch from 404a508 to 0355839 Compare October 21, 2024 12:22
nalcalag and others added 21 commits October 22, 2024 15:00
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208267346828963/f 

### Description

Adds a new DaxBubbleCardViewExperiment for upcoming experiment with onboarding.

These are not visible will be used later in another task. To see these dialogs they will need to be enabled in code.

### Steps to test this PR

_Launch onboarding_
- [ ] Ensure dialog shape and arrows have not changed 

### UI changes

There should be none. But here are examples of what the dialogs should look like when shown:

![Screenshot_20240926_121050](https://github.com/user-attachments/assets/480f2f4e-9e8d-44c7-a48c-48017f1afc9b)

![Screenshot_20240926_122205](https://github.com/user-attachments/assets/219a0875-9874-471e-ac01-bc83a8a4cc2f)

![Screenshot_20240926_155207](https://github.com/user-attachments/assets/17f96275-896a-4850-9ffe-96bb9716a8d9)
nalcalag and others added 5 commits October 22, 2024 15:00
Task/Issue URL:
https://app.asana.com/0/1207418217763355/1208542610603557/f

### Description

This PR removes the extra gap that was visible during onboarding. The
issue was mainly caused by
[this](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-38c52e4c3d2d7891eed9656823f30c41a4984cdeaa5f89a78e31f57340f6afbeL39).
Removing it, however, had a cascading side effect:

- A
[behavior](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-38c52e4c3d2d7891eed9656823f30c41a4984cdeaa5f89a78e31f57340f6afbeR25)
had to be added to the new browser tab layout so that the NTP content
would stay below the address bar now that the padding was removed
- The change above, caused some new layout changes, for example the
button on the NTP was now out of the viewport, so a bottom margin [had
to be
added](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-38c52e4c3d2d7891eed9656823f30c41a4984cdeaa5f89a78e31f57340f6afbeR45)
- The change above had a side effect that an unwanted gap was added to
the browser view during the partial onboarding, so some logic had to be
added bot to the
[bottom](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-fe6ebde9b11eddd212b40d9b12701a7e23e083cfc919c06b7a084d8f3e61154dR60)
and
[top](https://github.com/duckduckgo/Android/compare/feature/noelia/highlights_pre_onboarding...fix/ondrej/onboarding_gap?expand=1#diff-f5d61424e875a30ac1059375679a3bebb00e754e93a33f01d026019618bea1c0R45-R48)
bar behavior

### Steps to test this PR

_The toolbar is at the **top**_

- [x] Test the entire onboarding flow with the bar at the top and verify
no unwanted gaps are present
- [x] Test that the NTP looks correct, with the Edit button visible at
the bottom
- [x] Test the autocomplete list is scrollable and all items are visible
- [x] Test that browser layout looks correct with no unwanted gaps

_The toolbar is at the **bottom**_

- [x] Test the entire onboarding flow with the bar at the top and verify
no unwanted gaps are present
- [x] Test that the NTP looks correct, with the Edit button visible at
the bottom
- [x] Test the autocomplete list is scrollable and all items are visible
- [x] Test that browser layout looks correct with no unwanted gaps

---------

Co-authored-by: Noelia Alcala <[email protected]>
Co-authored-by: Mike Scamell <[email protected]>
@nalcalag nalcalag force-pushed the feature/noelia/highlights_pre_onboarding branch from ad24b48 to 6653bdf Compare October 22, 2024 14:00
@nalcalag nalcalag merged commit f6be916 into develop Oct 23, 2024
6 checks passed
@nalcalag nalcalag deleted the feature/noelia/highlights_pre_onboarding branch October 23, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants