Add functionality to auto-exclude #5062
Open
+1,084
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @karlenDimla and the rest of your teammates on |
This was referenced Sep 25, 2024
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
f124a4b
to
543a618
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
822d3d2
to
4046aac
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
b39a99e
to
d37f76b
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
4046aac
to
dd5a2a5
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
d37f76b
to
acd1461
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
dd5a2a5
to
e9613bf
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
acd1461
to
1c4eb39
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
e9613bf
to
01199f8
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
2 times, most recently
from
9d62f54
to
c814b2b
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
5642805
to
92b327e
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
c814b2b
to
d5b484b
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
92b327e
to
1c6dc14
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
d5b484b
to
cb6b112
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
1c6dc14
to
6f81fa1
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
cb6b112
to
efb282d
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
6f81fa1
to
0db27e5
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
2 times, most recently
from
e2617af
to
ee73013
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
ee73013
to
1787843
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
0db27e5
to
c95fc83
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
1787843
to
c511464
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
c95fc83
to
708eb1d
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
c511464
to
b1e2ccc
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
708eb1d
to
516def1
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
b1e2ccc
to
6f22a62
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
516def1
to
98a01f3
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
6f22a62
to
776d280
Compare
aitorvs
reviewed
Oct 22, 2024
...pl/src/main/java/com/duckduckgo/networkprotection/impl/autoexclude/AutoExcludeAppReceiver.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/duckduckgo/networkprotection/impl/exclusion/ui/NetpAppExclusionListViewModel.kt
Show resolved
Hide resolved
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
98a01f3
to
f182eb2
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
776d280
to
5c0b6c4
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/ui-prompt-exclusion
branch
from
f182eb2
to
5deaa51
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
5c0b6c4
to
f1d1973
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/functionality
branch
from
f1d1973
to
60e0ab0
Compare
aitorvs
approved these changes
Oct 24, 2024
| @@ -60,4 +62,10 @@ class RealAppTrackingProtection @Inject constructor( | |||
| vpnFeaturesRegistry.unregisterFeature(AppTpVpnFeature.APPTP_VPN) | |||
| } | |||
| } | |||
|
|
|||
| override suspend fun isAppExcluded(packageName: String): Boolean { | |||
| return withContext(dispatcherProvider.io()) { | |||
There was a problem hiding this comment.
nit: should we already define the dispatcher here? we know is disk IO
| * | ||
| * @return `true` when the app is excluded from App Tracking Protection | ||
| */ | ||
| suspend fun isAppExcluded(packageName: String): Boolean |
There was a problem hiding this comment.
nit: I was more thinking about getting the exclusion list as API, I think it's more generic. But fine
Task/Issue URL: https://app.asana.com/0/0/1208253921539950/f ### Description See attached task description ### Steps to test this PR https://app.asana.com/0/0/1208434633636283/f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208309647982860/f
Description
See attached description
Steps to test this PR
https://app.asana.com/0/72649045549333/1208398940490799/f