-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to auto-exclude #5062
base: feature/karl/vpn/ui-prompt-exclusion
Are you sure you want to change the base?
Add functionality to auto-exclude #5062
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @karlenDimla and the rest of your teammates on Graphite |
f124a4b
to
543a618
Compare
822d3d2
to
4046aac
Compare
b39a99e
to
d37f76b
Compare
4046aac
to
dd5a2a5
Compare
d37f76b
to
acd1461
Compare
dd5a2a5
to
e9613bf
Compare
acd1461
to
1c4eb39
Compare
e9613bf
to
01199f8
Compare
9d62f54
to
c814b2b
Compare
5642805
to
92b327e
Compare
c814b2b
to
d5b484b
Compare
92b327e
to
1c6dc14
Compare
d5b484b
to
cb6b112
Compare
1c6dc14
to
6f81fa1
Compare
cb6b112
to
efb282d
Compare
6f81fa1
to
0db27e5
Compare
e2617af
to
ee73013
Compare
ee73013
to
1787843
Compare
0db27e5
to
c95fc83
Compare
1787843
to
c511464
Compare
c95fc83
to
708eb1d
Compare
c511464
to
b1e2ccc
Compare
708eb1d
to
516def1
Compare
b1e2ccc
to
6f22a62
Compare
516def1
to
98a01f3
Compare
6f22a62
to
776d280
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments that I think should be addressed
...pl/src/main/java/com/duckduckgo/networkprotection/impl/autoexclude/AutoExcludeAppReceiver.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/duckduckgo/networkprotection/impl/exclusion/ui/NetpAppExclusionListViewModel.kt
Show resolved
Hide resolved
98a01f3
to
f182eb2
Compare
776d280
to
5c0b6c4
Compare
f182eb2
to
5deaa51
Compare
5c0b6c4
to
f1d1973
Compare
f1d1973
to
60e0ab0
Compare
@@ -60,4 +62,10 @@ class RealAppTrackingProtection @Inject constructor( | |||
vpnFeaturesRegistry.unregisterFeature(AppTpVpnFeature.APPTP_VPN) | |||
} | |||
} | |||
|
|||
override suspend fun isAppExcluded(packageName: String): Boolean { | |||
return withContext(dispatcherProvider.io()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we already define the dispatcher here? we know is disk IO
* | ||
* @return `true` when the app is excluded from App Tracking Protection | ||
*/ | ||
suspend fun isAppExcluded(packageName: String): Boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I was more thinking about getting the exclusion list as API, I think it's more generic. But fine
Task/Issue URL: https://app.asana.com/0/0/1208253921539950/f ### Description See attached task description ### Steps to test this PR https://app.asana.com/0/0/1208434633636283/f
Task/Issue URL: https://app.asana.com/0/72649045549333/1208309647982860/f
Description
See attached description
Steps to test this PR
https://app.asana.com/0/72649045549333/1208398940490799/f