Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] No reload gesture on "this page cant be loaded" page #3801

Closed
blackboxlogic opened this issue Nov 5, 2023 · 1 comment · Fixed by #4006
Closed

[Bug] No reload gesture on "this page cant be loaded" page #3801

blackboxlogic opened this issue Nov 5, 2023 · 1 comment · Fixed by #4006
Labels
bug needs triage

Comments

@blackboxlogic
Copy link

Describe the bug

Dragging a finger down to reload a page doesn't work on the page you get when a website failed to load.

How to Reproduce

Put your phone in airplane mode
Use DDG to browse to a web page
See "DDG cant load this page. The Internet connection appears to be offline" with a picture of Big foot walking by a fire
Turn off airplane mode
Try to refresh the page using the drag-down gesture
Gesture has no effect

Expected behavior

I expect the drag down page reload feature to work, even (especially) on error pages.

Environment

- DDG App Version: 5.176.3
- Device: pixel 3
- OS: Android 12
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

Thank you for opening an Issue in our Repository.
The issue has been forwarded to the team and we'll follow up as soon as we have time to investigate.
As stated in our Contribution Guidelines, requests for feedback should be addressed via the Feedback section in the Android app.

@joshliebe joshliebe changed the title No reload gesture on "this page cant be loaded" page [Bug] No reload gesture on "this page cant be loaded" page Nov 23, 2023
@marcosholgado marcosholgado mentioned this issue Dec 14, 2023
Merged
5 tasks
marcosholgado added a commit that referenced this issue Dec 15, 2023
@marcosholgado
Add pull to refresh when the error screen is shown (#4006)
9bd533b 
Task/Issue URL:
https://app.asana.com/0/1202552961248957/1205928683641648/f

### Description
This PR adds pull to refresh when the error screen is shown. Fixes
#3801

### Steps to test this PR

- [x] Go to any website
- [x] Put the phone in airplane mode
- [x] Refresh the website, yeti screen should shown
- [x] Pull to refresh should be possible 
- [x] Remove airplane mode and use pull to refresh, website should be
visible again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pull to refresh when the error screen is shown duckduckgo/Android
1 participant
@blackboxlogic