-
Notifications
You must be signed in to change notification settings - Fork 901
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Disconnect/re-connect from notification when both VPN and AppTP a…
…re enabled (#5154) Task/Issue URL: https://app.asana.com/0/488551667048375/1208536273997127/f ### Description Fix bug when both AppTP and VPN are enabled and user `disconnects` from the notification. When that happens two notifications are showed with CTAs to re-enable AppTP and VPN resp. Expected: * AppTP enable enables just ApptP * VPN enable just enables VPN Actual * either ApptP or VPN enable enable both ### Steps to test this PR _Test Fix_ - [x] Enable both AppTP and VPN - [x] In the combined AppTP/VPN notification press `Disconnect` - [x] Verify two notifications, for AppTP and VPN are shown - [x] Click on AppTP notification, enable CTA - [x] verify only AppTP is enabled - [x] Click on VPN notification, enable CTA - [x] verify only VPN is enabled - [x] repeat this test in the inverse order, before VPN then AppTP _Test combined notification_ - [x] After doing _Test Fix_ above - [x] open apps with trackers - [x] verify AppTP blocks trackers and combined notification works as expected - [x] smoke test _Test AppTP_ - [x] smoke test AppTP only _Test VPN_ - [x] smoke test VPN only
- Loading branch information
Showing
11 changed files
with
100 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.